Potential Bug - Error propagation for batch write during checkContext

arindombora21 · March 23, 2026, 7:28am

Description

PFA the description of the entire issue

github.com/weaviate/weaviate

Document count mismatch (documents ingested vs documents indexed) during batch write with CPU pressure.

opened 09:22AM - 18 Mar 26 UTC

arindombora21

bug community

### How to reproduce this bug? checkContext function has inverted logic causing… silent data loss during batch writes under timeout Component Module: adapters/repos/db File: shard_write_batch_objects.go Function: checkContext() (lines 441-456) ### What is the expected behavior? ``` func (ob *objectsBatcher) checkContext(ctx context.Context) bool { if err := ctx.Err(); err != nil { for i, objErr := range ob.errs { if objErr != nil { // already has an error, ignore continue } ob.errs[i] = errors.Wrapf(err, "inverted indexing complete, about to start vector indexing") } return false } return true } ``` This way object without errors but inactive context would also get captured. ### What is the actual behavior? ``` func (ob *objectsBatcher) checkContext(ctx context.Context) bool { if err := ctx.Err(); err != nil { for i, err := range ob.errs { if err == nil { // already has an error, ignore continue } ob.errs[i] = errors.Wrapf(err, "inverted indexing complete, about to start vector indexing") } return false } return true } ``` Here, when context has error, objects which did not have error are getting ignored instead of the ones with error(evident from the comment). This way if object had no error but context had an error, those errors never propagate back to the client. Also, the context error seems to be shadowed by the loop variable. ### Supporting information _No response_ ### Server Version 1.32.5 ### Weaviate Setup Multi-Node Cluster ### Nodes count 3 ### Code of Conduct - [x] I have read and agree to the Weaviate's [Contributor Guide](https://weaviate.io/developers/contributor-guide) and [Code of Conduct](https://weaviate.io/service/code-of-conduct)

Server Setup Information

Weaviate Server Version:
Deployment Method:
Multi Node? Number of Running Nodes:
Client Language and Version:
Multitenancy?:

Any additional Information

DudaNogueira · March 23, 2026, 8:43pm

hi @arindombora21 !!

Thanks for reporting!

Topic		Replies	Views
ObjectsGetResponse "double" error handling General	3	568	July 21, 2025
No error during indexing yet aggregate is off Support	5	772	July 20, 2023
Batch insert logs 'Failed to send 1 objects in a batch of 1' but collection.batch.failed_objects is empty Support python	11	1409	November 19, 2024
Batch insert error Support	1	500	November 21, 2024
BUG: Batcher doesn't upload the objects to the weaviate db Support	3	478	November 10, 2024

Potential Bug - Error propagation for batch write during checkContext

Description

Server Setup Information

Any additional Information

Related topics